<html>
<head><meta charset="utf-8"><title>Guidelines for asking for reviewer feedback · general · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/index.html">general</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Guidelines.20for.20asking.20for.20reviewer.20feedback.html">Guidelines for asking for reviewer feedback</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="210106234"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Guidelines%20for%20asking%20for%20reviewer%20feedback/near/210106234" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Hameer Abbasi <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Guidelines.20for.20asking.20for.20reviewer.20feedback.html#210106234">(Sep 15 2020 at 09:08)</a>:</h4>
<p>Hello, are there guidelines for asking for reviewer feedback? For example, when to request a re-review, what to tag them in, etc? Or is it down to personal preference?</p>



<a name="210118594"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Guidelines%20for%20asking%20for%20reviewer%20feedback/near/210118594" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Guidelines.20for.20asking.20for.20reviewer.20feedback.html#210118594">(Sep 15 2020 at 11:52)</a>:</h4>
<p>I'm not aware of any guidelines - do whatever seems reasonable and sensible, or ask them what they prefer.</p>



<a name="210118669"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Guidelines%20for%20asking%20for%20reviewer%20feedback/near/210118669" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Guidelines.20for.20asking.20for.20reviewer.20feedback.html#210118669">(Sep 15 2020 at 11:53)</a>:</h4>
<p>I expect that reviewers won't mind requests for re-review or being pinged (some folks get a lot of pings and so might not see it, but I don't think anyone actively doesn't want pinged).</p>



<a name="210121554"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Guidelines%20for%20asking%20for%20reviewer%20feedback/near/210121554" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Guidelines.20for.20asking.20for.20reviewer.20feedback.html#210121554">(Sep 15 2020 at 12:26)</a>:</h4>
<p>FWIW I'd personally find a zulip PM much more useful because github pings are indeed likely to get lost</p>



<a name="210121665"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Guidelines%20for%20asking%20for%20reviewer%20feedback/near/210121665" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Guidelines.20for.20asking.20for.20reviewer.20feedback.html#210121665">(Sep 15 2020 at 12:27)</a>:</h4>
<blockquote>
<p>FWIW I'd personally find a zulip PM much more useful because github pings are indeed likely to get lost</p>
</blockquote>
<p>oops, let me ping <span class="user-mention" data-user-id="116122">@simulacrum</span> here too then ;) for <a href="https://github.com/rust-lang/rust/issues/76733">https://github.com/rust-lang/rust/issues/76733</a></p>



<a name="210121683"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Guidelines%20for%20asking%20for%20reviewer%20feedback/near/210121683" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Guidelines.20for.20asking.20for.20reviewer.20feedback.html#210121683">(Sep 15 2020 at 12:27)</a>:</h4>
<p>already looking at that</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>